Fix: Error Handling & Validation Improvements#1719
Open
rachit23tech wants to merge 2 commits intoopenml:mainfrom
Open
Fix: Error Handling & Validation Improvements#1719rachit23tech wants to merge 2 commits intoopenml:mainfrom
rachit23tech wants to merge 2 commits intoopenml:mainfrom
Conversation
Author
|
Hi maintainers, could you please approve the workflows so CI checks can run? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
Details
This PR improves error handling and validation in the
OpenMLDataFeatureclass and enhances dataset parsing logic for better consistency and robustness.What does this PR implement/fix?
indexparameter to ensure it is non-negativenameparameter to ensure it is a non-empty stringnumber_missing_valuesto ensure it is non-negativenominal_valuesAdditionally:
_parse_features_xmlindataset.pyto better handle ontologiesnr_missingWhy is this change necessary?
Previously, insufficient validation could lead to unclear errors or unexpected behavior when working with dataset features. This update improves reliability, enforces correct input handling, and enhances the overall developer experience.
Testing
pytesttest_get_feature_with_ontology_data_id_11) due to pre-existing outdated expectationsAdditional Notes
The failing test appears to expect multiple ontologies, while the API currently returns only one. The implemented parsing correctly reflects the actual API behavior.