Closed
Conversation
…ase to QueryFixtureBase<T> Update TimestampQueryFixture, NodaTimeQueryNpgsqlFixture, BigIntegerQueryFixture, and EnumFixture to inherit from QueryFixtureBase<T> instead of SharedStoreFixtureBase<T> with IQueryFixtureBase. Remove GetContextCreator() (provided by base class) and change GetExpectedData(), EntitySorters, and EntityAsserters to override. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: roji <1862641+roji@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix synchronization workflow failure with latest EF
Sync to EF 11.0.0-preview.3.26154.119
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates EFCore.PG to reference the latest EF Core daily build for preview.3, adapting to breaking changes from dotnet/efcore#37681 and dotnet/efcore#37732.
Version bump
Directory.Packages.props:11.0.0-preview.2.26154.117→11.0.0-preview.3.26154.119NonSharedModelTestBase renames (dotnet/efcore#37681)
Across ~24 test files:
TestStoreFactory→NonSharedTestStoreFactoryInitializeAsync<T>→InitializeNonSharedTest<T>contextFactory.CreateContext→contextFactory.CreateDbContextStoreName→NonSharedStoreNameNonSharedPrimitiveCollectionsQuery removal (dotnet/efcore#37681)
NonSharedPrimitiveCollectionsQueryRelationalTestBasewas removed upstream and merged intoPrimitiveCollectionsQueryRelationalTestBase. DeletedNonSharedPrimitiveCollectionsQueryNpgsqlTest.csand merged its tests (Multidimensional_array_is_not_supported,Column_collection_inside_json_owned_entity, GIN/btree index tests,SetParameterizedCollectionMode) intoPrimitiveCollectionsQueryNpgsqlTest.QueryFixtureBase introduction (dotnet/efcore#37681)
5 fixture classes (
ArrayQueryFixture,TimestampQueryFixture,NodaTimeQueryNpgsqlFixture,BigIntegerQueryFixture,EnumFixture) changed fromSharedStoreFixtureBase<T>, IQueryFixtureBase→QueryFixtureBase<T>, removing now-redundantGetContextCreator()and switching interface members tooverride.JsonExists → JsonPathExists (dotnet/efcore#37732)
EF Core renamed
RelationalDbFunctionsExtensions.JsonExiststoJsonPathExiststo avoid conflict with the existing Npgsql-specificJsonExists(PostgreSQL?operator). Updated test overrides and simplifiedRemoveJsonPropertysignature — base class no longer passes$.prefix.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
37cvsblobprodcus359.vsblob.vsassets.io/tmp/dotnet11/dotnet dotnet restore(dns block)/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/efcore.pg/efcore.pg/EFCore.PG.slnx --packages /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true -d: alTests/TPTTableSplittingNpgsqlTest.cs s1877305184 /usr/bin/bash SharedTestStoreFrunc io.containerd.ru--root 1c998513990bb417/var/run/docker/runtime-runc/moby bash(dns block)/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/efcore.pg/efcore.pg/test/EFCore.PG.FunctionalTests/EFCore.PG.FunctionalTests.csproj --packages /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true 18e/�� runtime-runc/mob/opt/hostedtoolcache/CodeQL/2.24.2/x64/codeql/tools/codeql.jar y io.containerd.rudatabase ntime.v2.task/mocp 9aeab4c71154caaf-R(dns block)4zjvsblobprodcus390.vsblob.vsassets.io/tmp/dotnet11/dotnet dotnet build(dns block)/tmp/dotnet11/dotnet dotnet build --source REDACTED --source REDACTED --source REDACTED 4179aeab4c71154caaff3370933a3c4b18e/748336a5c577b96332b2a687197f14795b3ee3e3dc8123d819de330483bf--scope(dns block)7k6vsblobprodcus337.vsblob.vsassets.io/tmp/dotnet11/dotnet dotnet build(dns block)/tmp/dotnet11/dotnet dotnet build --source REDACTED --source REDACTED --source REDACTED 4179aeab4c71154caaff3370933a3c4b18e/748336a5c577b96332b2a687197f14795b3ee3e3dc8123d819de330483bf--scope(dns block)7tjvsblobprodcus341.vsblob.vsassets.io/tmp/dotnet11/dotnet dotnet restore(dns block)/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/efcore.pg/efcore.pg/EFCore.PG.slnx --packages /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true -d: alTests/TPTTableSplittingNpgsqlTest.cs s1877305184 /usr/bin/bash SharedTestStoreFrunc io.containerd.ru--root 1c998513990bb417/var/run/docker/runtime-runc/moby bash(dns block)/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/efcore.pg/efcore.pg/src/EFCore.PG/EFCore.PG.csproj --packages /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true f5c3�� test/EFCore.PG.FunctionalTests/Query/Translations/RangeTranslati/run/containerd/io.containerd.ru/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet y /usr/lib/postgresql/17/bin/pg_isready ntime.v2.task/mocp y rgo/bin/bash 25062281f967acbd/tmp/dotnet.X2HhMaZ7Y/sdk-manifests/11.0.100-preview.1/microsoft.net.sdk.maccata/low:false(dns block)aka.ms/usr/bin/curl curl -I -sSL --retry 5 --retry-delay 2 --connect-timeout 15 REDACTED(dns block)jrqvsblobprodcus343.vsblob.vsassets.io/tmp/dotnet11/dotnet dotnet build(dns block)/tmp/dotnet11/dotnet dotnet build --source REDACTED --source REDACTED --source REDACTED 4179aeab4c71154caaff3370933a3c4b18e/748336a5c577b96332b2a687197f14795b3ee3e3dc8123d819de330483bf--scope(dns block)k0ivsblobprodcus356.vsblob.vsassets.io/tmp/dotnet11/dotnet dotnet build(dns block)/tmp/dotnet11/dotnet dotnet build --source REDACTED --source REDACTED --source REDACTED 4179aeab4c71154caaff3370933a3c4b18e/748336a5c577b96332b2a687197f14795b3ee3e3dc8123d819de330483bf--scope(dns block)k4kvsblobprodcus344.vsblob.vsassets.io/tmp/dotnet11/dotnet dotnet restore(dns block)/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/efcore.pg/efcore.pg/EFCore.PG.slnx --packages /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true -d: alTests/TPTTableSplittingNpgsqlTest.cs s1877305184 /usr/bin/bash SharedTestStoreFrunc io.containerd.ru--root 1c998513990bb417/var/run/docker/runtime-runc/moby bash(dns block)/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/efcore.pg/efcore.pg/test/EFCore.PG.Tests/EFCore.PG.Tests.csproj --packages /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true 18e/�� -f1 y /opt/containerd/bin/bash ntime.v2.task/momkdir /tmp/dotnet.QqQL-p 7fa1c998513990bb/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/sdk-manifests/11/nodeReuse:false iginal(dns block)o3svsblobprodcus318.vsblob.vsassets.io/tmp/dotnet11/dotnet dotnet restore(dns block)/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/efcore.pg/efcore.pg/test/EFCore.PG.FunctionalTests/EFCore.PG.FunctionalTests.csproj --packages /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true 18e/�� runtime-runc/mob/opt/hostedtoolcache/CodeQL/2.24.2/x64/codeql/tools/codeql.jar y io.containerd.rudatabase ntime.v2.task/mocp 9aeab4c71154caaf-R(dns block)pc2vsblobprodcus360.vsblob.vsassets.io/tmp/dotnet11/dotnet dotnet restore(dns block)/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/efcore.pg/efcore.pg/EFCore.PG.slnx --packages /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true -d: alTests/TPTTableSplittingNpgsqlTest.cs s1877305184 /usr/bin/bash SharedTestStoreFrunc io.containerd.ru--root 1c998513990bb417/var/run/docker/runtime-runc/moby bash(dns block)/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/efcore.pg/efcore.pg/test/EFCore.PG.Tests/EFCore.PG.Tests.csproj --packages /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true 18e/�� -f1 y /opt/containerd/bin/bash ntime.v2.task/momkdir /tmp/dotnet.QqQL-p 7fa1c998513990bb/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/sdk-manifests/11/nodeReuse:false iginal(dns block)s8mvsblobprodcus38.vsblob.vsassets.io/tmp/dotnet11/dotnet dotnet restore(dns block)/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/efcore.pg/efcore.pg/EFCore.PG.slnx --packages /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true -d: alTests/TPTTableSplittingNpgsqlTest.cs s1877305184 /usr/bin/bash SharedTestStoreFrunc io.containerd.ru--root 1c998513990bb417/var/run/docker/runtime-runc/moby bash(dns block)/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/dotnet restore --no-dependencies /home/REDACTED/work/efcore.pg/efcore.pg/test/EFCore.PG.Tests/EFCore.PG.Tests.csproj --packages /tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true 18e/�� -f1 y /opt/containerd/bin/bash ntime.v2.task/momkdir /tmp/dotnet.QqQL-p 7fa1c998513990bb/tmp/codeql-scratch-a20bfa1f1f244e03/dbs/csharp/working/.dotnet/sdk-manifests/11/nodeReuse:false iginal(dns block)u6ovsblobprodcus377.vsblob.vsassets.io/tmp/dotnet11/dotnet dotnet build(dns block)/tmp/dotnet11/dotnet dotnet build --source REDACTED --source REDACTED --source REDACTED 4179aeab4c71154caaff3370933a3c4b18e/748336a5c577b96332b2a687197f14795b3ee3e3dc8123d819de330483bf--scope(dns block)vb4vsblobprodcus33.vsblob.vsassets.io/tmp/dotnet11/dotnet dotnet build(dns block)/tmp/dotnet11/dotnet dotnet build --source REDACTED --source REDACTED --source REDACTED 4179aeab4c71154caaff3370933a3c4b18e/748336a5c577b96332b2a687197f14795b3ee3e3dc8123d819de330483bf--scope(dns block)www.myget.org/tmp/dotnet11/dotnet dotnet build(dns block)/tmp/dotnet11/dotnet dotnet build --source REDACTED --source REDACTED --source REDACTED 4179aeab4c71154caaff3370933a3c4b18e/748336a5c577b96332b2a687197f14795b3ee3e3dc8123d819de330483bf--scope(dns block)/tmp/dotnet11/dotnet dotnet restore(dns block)ytvvsblobprodcus310.vsblob.vsassets.io/tmp/dotnet11/dotnet dotnet build(dns block)/tmp/dotnet11/dotnet dotnet build --source REDACTED --source REDACTED --source REDACTED 4179aeab4c71154caaff3370933a3c4b18e/748336a5c577b96332b2a687197f14795b3ee3e3dc8123d819de330483bf--scope(dns block)/tmp/dotnet11/dotnet dotnet restore(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.