Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I want to make node more friendly for new user. Actually it take me very long to find out node repl can load script :)
Also I am not quite sure I put the change in best location in
repl.js.Welcome message
The current welcome message is (copyed from windows powershell):
Compare with other languages
In python (using
docker run --rm -it python):In java (use
docker run --rm -it openjdk:11):May need port to Node 8 && 10.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes