fix: Keep raw message on smtp/mime failure

[kesselb]

I'm undecided about it.

---

The use case/steps to reproduce:

• Send an email with "info@test" as recipient
• See the message is stuck in the oc_mail_local_messages
• Troubleshooting is hard without knowing the actual message going out (it might be something different than a weird recipient)

[kesselb]

/backport to stable5.7

[Copilot]

Pull request overview

This PR improves outbox troubleshooting by trying to persist the RFC822 “raw” message into mail_local_messages.raw even when SMTP/MIME sending fails, instead of only persisting raw on successful send.

Changes:

• Import Throwable and use non-capturing catch (Throwable) for consistency.
• On non-retriable Horde_Mime_Exception, attempt to store $mail->getRaw(false) into the LocalMessage before marking it STATUS_ERROR.
• Keep SMTP logout failures silent using the same Throwable import.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The early return for retriable SMTP codes happens before the new best-effort raw capture, so messages ending up in STATUS_SMPT_SEND_FAIL still won't have raw stored for troubleshooting. If the intent is to “keep raw message on smtp/mime failure”, consider moving the raw-capture attempt before this return (or explicitly capturing raw for this status as well).

[kesselb]

I don't see the point of storing the raw message for a temporary issue by the remote. That's nothing we can fix / where having the raw message would help to troubleshoot.

[Copilot]

New behavior now attempts to persist the raw RFC822 message when Horde_Mime_Exception occurs (non-retriable path), but there doesn't appear to be unit/integration coverage asserting that LocalMessage::getRaw() is populated (and that failures in getRaw(false) are tolerated). Adding a focused test would prevent regressions in this troubleshooting path.

[kesselb]

😕

[kesselb]

lib/Service/MailTransmission.php:329:5: PossiblyInvalidArgument: Argument 3 of OCA\Mail\IMAP\MessageMapper::save expects string, but possibly different type resource|string provided

True, but that also a different method I didn't even touch 🤷

bytestream/Mime#15 should help.

[kesselb]

Error: lib/Service/MailTransmission.php:244:5: PossiblyNullArgument: Argument 3 of OCA\Mail\IMAP\MessageMapper::save cannot be null, possibly null value provided (see https://psalm.dev/078)
Error: lib/Service/MailTransmission.php:330:5: PossiblyNullArgument: Argument 3 of OCA\Mail\IMAP\MessageMapper::save cannot be null, possibly null value provided (see https://psalm.dev/078)

Classic MessageMapper != MessageMapper 🤣 🙈