Skip to content

Dashboards: Filter by client ID#7284

Merged
bendk merged 1 commit intomozilla:mainfrom
bendk:push-kmuvntvkrnrn
Mar 23, 2026
Merged

Dashboards: Filter by client ID#7284
bendk merged 1 commit intomozilla:mainfrom
bendk:push-kmuvntvkrnrn

Conversation

@bendk
Copy link
Contributor

@bendk bendk commented Mar 23, 2026

Renamed "Search details" to "Search" and have it match against client_id as well.

Use the grafana sqlstring format more, rather than trying to quote the strings ourselves.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Renamed "Search details" to "Search" and have it match against client_id
as well.

Use the grafana `sqlstring` format more, rather than trying to quote the
strings ourselves.
@bendk bendk requested review from a team and skhamis March 23, 2026 14:00
Copy link
Contributor

@skhamis skhamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bendk bendk added this pull request to the merge queue Mar 23, 2026
Merged via the queue into mozilla:main with commit 461f7b0 Mar 23, 2026
13 checks passed
@bendk bendk deleted the push-kmuvntvkrnrn branch March 23, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants