Skip repo info diff when commit count exceeds limit#4309
Draft
tyrielv wants to merge 1 commit intomicrosoft:mainfrom
Draft
Skip repo info diff when commit count exceeds limit#4309tyrielv wants to merge 1 commit intomicrosoft:mainfrom
tyrielv wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Add MAX_DIFF_COMMITS (30) check using repository.log() with a range of mergeBase..HEAD. If the number of commits returned hits the limit, return early with a 'tooManyCommits' result to avoid expensive diff operations on branches with large commit ranges. Add optional commitCount measurement to telemetry, populated only when the commit count is within the limit.
Author
|
This is one proposal for fixing the performance issues that VFS users in large repositories are seeing with this extension. I have another at #4308. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MAX_DIFF_COMMITS (30) check using repository.log() with a range of mergeBase..HEAD. If the number of commits returned hits the limit, return early with a 'tooManyCommits' result to avoid expensive diff operations on branches with large commit ranges.
Add optional commitCount measurement to telemetry, populated only when the commit count is within the limit.