Skip to content

Update TypeScript compilation target to es2022 for node rigs and projects#5667

Draft
Copilot wants to merge 5 commits intomainfrom
copilot/update-default-target-node-rigs
Draft

Update TypeScript compilation target to es2022 for node rigs and projects#5667
Copilot wants to merge 5 commits intomainfrom
copilot/update-default-target-node-rigs

Conversation

Copy link
Contributor

Copilot AI commented Feb 23, 2026

  • Identify all change files from previous session (16 files in common/changes/@rushstack/)
  • Check each package version to determine correct change type
  • Updated all change types to minor per reviewer feedback
  • Fixed CI build failures: added declare modifier to MarkdownDocumenterFeature.context and BaseRushAction.rushConfiguration (TS2612)
  • Fixed change file: moved from @microsoft/rush-lib to @microsoft/rush per reviewer feedback
  • patch change files for @microsoft/api-documenter and @microsoft/rush

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…ects

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Copilot AI changed the title [WIP] Update default target for node rigs to minimum supported version Update default TypeScript compilation target to es2022 for node rigs and projects Feb 24, 2026
Copilot AI requested a review from dmichon-msft February 24, 2026 00:12
…< 1.0.0

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Copilot AI changed the title Update default TypeScript compilation target to es2022 for node rigs and projects Update TypeScript compilation target to es2022 for node rigs and projects Feb 24, 2026
{
"packageName": "@rushstack/heft-jest-plugin",
"comment": "Update TypeScript compilation target to es2022 to match the minimum supported Node.js version (18.15.0)",
"type": "major"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these should not be "major" bumps.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything with an 0. version we still use minor for "breaking change".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed all major bumps to minor in commit c1d8c9f. All 16 change files now use minor (for packages ≥ 1.x) or minor (for 0.x packages), consistent with the minor-for-breaking-change convention.

@dmichon-msft
Copy link
Contributor

@copilot There are build failures due to property redeclarations in inherited classes. Add the declare modifier to the offending property declarations.

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 9, 2026

@copilot There are build failures due to property redeclarations in inherited classes. Add the declare modifier to the offending property declarations.

Fixed in commit c1d8c9f. Added declare modifier to two property redeclarations that triggered TS2612 with the ES2022 target:

  • apps/api-documenter/src/plugin/MarkdownDocumenterFeature.ts: public declare context: MarkdownDocumenterFeatureContext
  • libraries/rush-lib/src/cli/actions/BaseRushAction.ts: protected declare readonly rushConfiguration: RushConfiguration

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs triage

Development

Successfully merging this pull request may close these issues.

3 participants