Draft
Conversation
- Replace `run-parallel-limit` (callback-based) with `p-limit` v7.3.0 (promise-based) - Remove `@types/run-parallel-limit` dev dependency (p-limit ships its own types) - Update cleanTask.ts: convert to async function using p-limit - Update copyTask.ts: convert to async function, wrap stream operations in promises - Update sassTask.ts: wrap callback-based tasks in promises, use p-limit for concurrency Co-authored-by: ecraig12345 <5864305+ecraig12345@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/just/sessions/defe8523-a502-4f0a-9655-e353589f4cbb
…ing in sassTask Co-authored-by: ecraig12345 <5864305+ecraig12345@users.noreply.github.com> Agent-Logs-Url: https://github.com/microsoft/just/sessions/defe8523-a502-4f0a-9655-e353589f4cbb
Copilot
AI
changed the title
[WIP] Replace run-parallel-limit with p-limit
Replace Mar 26, 2026
run-parallel-limit with p-limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the callback-based
run-parallel-limitwith the promise-basedp-limitv7.3.0 (latest). Despite being ESM-only, it works because Node 22+ supportsrequire()of synchronous ESM modules.Changes
cleanTask.ts— Converted to async;fse.remove()already returns a promise, so callbacks are no longer neededcopyTask.ts— Converted to async; stream operations wrapped in promises with properwriteStream.on('finish')(previously usedreadStream.on('end')which could resolve before the write completes)sassTask.ts—sass.rendercallbacks wrapped in promises; added missing.catch(reject)on the postcss promise chainpackage.json— Addedp-limit@^7.3.0, removedrun-parallel-limitand@types/run-parallel-limitBefore/After
Public API surface is unchanged per
api-extractor.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
ofcncog2cu-dsn.algolia.net/opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node /home/REDACTED/work/just/just/.yarn/releases/yarn-4.13.0.cjs add p-limit@latest(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.