Skip to content

Changing localization.yml for proper authentication and translation#825

Open
pranjal-glowingstar wants to merge 16 commits intomasterfrom
pranjal/testingpipeline
Open

Changing localization.yml for proper authentication and translation#825
pranjal-glowingstar wants to merge 16 commits intomasterfrom
pranjal/testingpipeline

Conversation

@pranjal-glowingstar
Copy link
Copy Markdown
Collaborator

@pranjal-glowingstar pranjal-glowingstar commented Mar 19, 2026

Problem

The pipeline for localization(localization.yml) was always giving error when running leading to no translations and no pull request raise.

Root cause

There were 3 main issues with the flow

  1. The app registration for FluentUi-Android was not done. The previous app registration was deleted somehow due to which the authentication and authorization both were impacted. Application client ID and application client secret present in repository secrets were useless.

  2. The authentication mechanism required change from client secret type to federated credentials. Instead of passing client ID and client secret, we are using OIDC mechanism to get a token in runtime and then authenticate ourselves.

  3. The new team created required its client ID addition in touchdown build team to provide proper authorization and remove the 403 forbidden error.

Fix

We have added a new app registration with the same name(FluentUi-Android), added federated credentials, updated the repository secrets with correct client ID and added this tenant in touchdown build's team.

Validations

Pipeline running successfully, translations happening and PR begin raised automatically.

(how the change was tested, including both manual and automated tests)

Screenshots

Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • Automated Tests
  • Documentation and demo app examples
  • VoiceOver and Keyboard Accessibility
  • Internationalization and RTL layouts
  • Size classes and window sizes (notched devices, multitasking, different window sizes, etc)

@pranjal-glowingstar pranjal-glowingstar requested a review from a team as a code owner March 19, 2026 17:33
Copilot AI review requested due to automatic review settings March 19, 2026 17:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds verbose tracing/logging to the localization scripts to aid debugging and validation of localization runs.

Changes:

  • Enable shell tracing with timestamped PS4 and add start/end banners and runtime metrics.
  • Add pre/post run “visibility” logs (env/git/status, directory listings, checksums).
  • Refactor formatting in GetLocalizedFiles.sh and expand curl verbosity/output diagnostics.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 23 comments.

File Description
localize.sh Adds extensive tracing and pre/post diagnostics; reformats and shortens localization fetch calls.
GetLocalizedFiles.sh Adds tracing and more verbose curl diagnostics; refactors parsing/loop logic and changes file handling behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Removed oauthToken function implementation that fetched an OAuth token.
Updated script to use pre-fetched OIDC token instead of client ID and secret.
Updated the process for obtaining the TouchDown Build access token using GitHub OIDC federated token.
Updated the TouchDown Build access token exchange endpoint and added clarification in comments.
Added error handling for access token retrieval in localization workflow.
Updated the OAuth token exchange endpoint from v1.0 to v2.0 for improved compatibility.
Removed extensive logging and tracing from the script. Consolidated multiple calls to GetLocalizedFiles.sh into a single line for each localization.
Refactor logging and argument parsing in GetLocalizedFiles.sh. Update echo statements for better clarity and modify OAuth handling.
Updated GITHUB_TOKEN to use secrets.GH_TOKEN and modified pull request head reference.
@pranjal-glowingstar pranjal-glowingstar changed the title Testing localization scripts with proper logs Changing localization.yml for proper authentication and translation Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants