<filesystem>: Set the error code for fs::absolute("", ec).#6132
Open
leejy12 wants to merge 3 commits intomicrosoft:mainfrom
Open
<filesystem>: Set the error code for fs::absolute("", ec).#6132leejy12 wants to merge 3 commits intomicrosoft:mainfrom
<filesystem>: Set the error code for fs::absolute("", ec).#6132leejy12 wants to merge 3 commits intomicrosoft:mainfrom
Conversation
Contributor
|
The error code for calling |
Contributor
Author
|
@YexuanXiao I intended to let Lines 156 to 160 in 117ca96 But libstdc++ sets the error to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6120
fs::absolute("", ec)was returning an emptypath, indicating an error has occurred, but didn't setecto the appropriateerror_code.libstdc++ treats this call as an error, whereas libc++ treats it as a success case.
[fs.op.absolute#1] says the function "Composes an absolute path referencing the same file system location as p according to the operating system". On Windows,
GetFullPathNameW(L"", ...)fails, so following libstdc++’s behavior is more consistent with the standard wording.This change updates the implementation to set
ec.value()to 123 (ERROR_INVALID_NAME).