Change pagefile display write type color to Green#2523
Change pagefile display write type color to Green#2523trudolf-msft wants to merge 1 commit intomicrosoft:mainfrom
Conversation
If recommended value is correct it should show as green. Customer was confused and did check manually
There was a problem hiding this comment.
Pull request overview
Updates HealthChecker OS analysis output so a correctly configured Exchange 2019 pagefile is shown as a “good” (Green) result, reducing customer confusion when verifying recommendations.
Changes:
- Change PageFile “matches recommendation” DisplayWriteType from Grey to Green for the Exchange 2019 sizing branch.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } elseif ($recommendedPageFile -ne $pageFileObj.MaxPageSize) { | ||
| $pageFileAdditionalDisplayValue = ("Warning: $recommendedPageFileWording2019" -f $recommendedPageFile, $totalPhysicalMemory) | ||
| } else { | ||
| $displayWriteType = "Grey" | ||
| $displayWriteType = "Green" | ||
| } |
There was a problem hiding this comment.
This change makes the Exchange 2019 “pagefile matches recommendation” case show as Green, but the other “matches recommendation” branches in the same PageFile analyzer still set $displayWriteType to "Grey" (e.g., non-2019 32GB+ exact 32778, and <32GB exact totalMemory+10). If the intent (per PR description and HealthChecker.ps1 notes) is that settings matching recommendations are Green, those branches should be updated as well for consistent behavior.
| $pageFileAdditionalDisplayValue = ("Warning: $recommendedPageFileWording2019" -f $recommendedPageFile, $totalPhysicalMemory) | ||
| } else { | ||
| $displayWriteType = "Grey" | ||
| $displayWriteType = "Green" |
There was a problem hiding this comment.
There are Pester scenarios validating PageFile behavior, but none assert the WriteType for the “configured as expected” case. Since this PR changes the PageFile DisplayWriteType to Green when it matches the recommendation, please add/adjust a test assertion so the color regression is covered (e.g., assert GetWriteTypeObject "PageFile Size 0" is Green for the well-configured Exchange 2019 scenario).
If recommended value is correct it should show as green. Customer was confused and did check manually