Fix .be and .pl TLD parsing; add google.be, wp.pl and domena.pl tests#39
Open
Misiu wants to merge 1 commit intomboot-github:masterfrom
Open
Fix .be and .pl TLD parsing; add google.be, wp.pl and domena.pl tests#39Misiu wants to merge 1 commit intomboot-github:masterfrom
Misiu wants to merge 1 commit intomboot-github:masterfrom
Conversation
…fixture (#1) * Fix .pl domain whois: use whois.dns.pl server, fix be TLD, add test data * Fix ZZ["be"]: extend com, add server/test, fix registrar regex; add google.be testdata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My intention is to replace old whois library in Home Assistant as it is not parsing PL domains correctly and it is not maintained anymore.
While working on an update, I noticed that in the current version, the PL also does not work.
I installed whois on Windows and Linux, got a couple of responses, and created this PR.
After this gets approved, merged, and released as a new version, the next step will be to update the library on the Home Assistant side.