Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Closes epic #11 by tightening documentation and adding focused automated tests around the control-plane domain contracts (#22) and runtime communication contracts (#23), clarifying that epic #12 builds on (rather than re-owns) these foundation slices.
Changes:
- Added slice-aligned contract tests for version-7 identifiers, serialization-safe defaults, and deterministic
ManagedCode.Communicationresult/problem flows. - Updated architecture/ADR/feature docs to correctly position #11 as the foundation for #12 and added targeted
dotnet test --filter ...verification commands. - Removed user-specific paths from domain contract test fixtures and updated runtime foundation summary wording.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| epic-11-foundation-contracts.plan.md | Adds an epic close-out plan + validation notes for #11/#22/#23. |
| docs/Features/runtime-communication-contracts.md | Adds focused verification command for RuntimeCommunication tests. |
| docs/Features/control-plane-domain-model.md | Adds focused verification command and corrects parent epic reference to #11. |
| docs/Architecture.md | Reframes architecture map so #11 is the foundation and #12 builds on it; updates diagrams/links. |
| docs/ADR/ADR-0003-vertical-slices-and-ui-only-uno-app.md | Updates ADR language to reflect #11 as the contract foundation before #12. |
| DotPilot.Tests/Features/RuntimeCommunication/DeterministicAgentRuntimeClientContractTests.cs | New tests asserting deterministic runtime client success + typed problem flows. |
| DotPilot.Tests/Features/ControlPlaneDomain/ControlPlaneIdentifierContractTests.cs | New tests asserting v7 identifiers + serialization-safe defaults for domain descriptors/records. |
| DotPilot.Tests/ControlPlaneDomainContractsTests.cs | Replaces user-specific RootPath and updates BranchName fixture value. |
| DotPilot.Runtime/Features/RuntimeFoundation/RuntimeFoundationCatalog.cs | Updates epic summary string to reflect #11 foundation contracts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
…ion-contracts # Conflicts: # DotPilot.Runtime/Features/RuntimeFoundation/RuntimeFoundationCatalog.cs # DotPilot.Tests/Features/ControlPlaneDomain/ControlPlaneDomainContractsTests.cs # docs/ADR/ADR-0003-vertical-slices-and-ui-only-uno-app.md # docs/Architecture.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#11by closing the remaining documentation and verification gaps around the#22control-plane domain contracts and#23runtime communication contractsManagedCode.Communicationresult/problem flows#11is the shared contract foundation and epic#12builds on it instead of re-owning issues#22and#23Verification
dotnet test DotPilot.Tests/DotPilot.Tests.csproj --filter "FullyQualifiedName~ControlPlaneDomain|FullyQualifiedName~RuntimeCommunication"dotnet build DotPilot.slnx -warnaserror -m:1 -p:BuildInParallel=falsedotnet test DotPilot.slnxdotnet format DotPilot.slnx --verify-no-changesdotnet test DotPilot.Tests/DotPilot.Tests.csproj --settings DotPilot.Tests/coverlet.runsettings --collect:"XPlat Code Coverage"Closes #11
Closes #22
Closes #23