Fix UseToStringAsLabel on SubclassSelector attribute#99
Open
jhodk wants to merge 1 commit intomackysoft:mainfrom
Open
Fix UseToStringAsLabel on SubclassSelector attribute#99jhodk wants to merge 1 commit intomackysoft:mainfrom
jhodk wants to merge 1 commit intomackysoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I am using unity editor version 6000.3.7f1.
The property
UseToStringAsLabelon theSubclassSelectorattribute does not currently appear to have any impact on the GUI render.According to this code on the current main branch, we would expect the
foodThreeexample field to be rendered in the editor with label "Grape".Unity-SerializeReferenceExtensions/Assets/Example/Example.cs
Lines 73 to 75 in e23441e
However the left side of the screenshot below shows that is not the case - the name remains as "Food Three".
Changes made
EditorGUI.BeginPropertycalls after thelabel.textoverride.ToStringoverride in Food example classFoods Threeto Example script withUseToStringAsLabel = trueScreenshots
Left is before the fix, Right is after the fix

Thanks.