Integration tests for NB Front-End IP & 40Gbps#664
Conversation
mawilk90
requested review from
ckulinsk and
jriddle-linode
and removed request for
a team
mawilk90
requested review from
dawiddzhafarov,
ezilber-akamai and
psnoch-akamai
and removed request for
jriddle-linode
There was a problem hiding this comment.
Pull request overview
Adds integration coverage for NodeBalancer Front-End IP behavior in VPCs (including single-stack IPv4) and validates the premium_40gb NodeBalancer type behavior.
Changes:
- Added NodeBalancer integration tests for backend-only VPC attachment, frontend VPC IP assignment, and mixed frontend/backend VPC configurations.
- Added new VPC fixtures for IPv4-only VPC/subnet creation to support single-stack frontend tests.
- Updated VPC fixture region capability selection to include additional capabilities needed by the new NodeBalancer/VPC scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
test/integration/models/nodebalancer/test_nodebalancer.py |
Adds new integration tests covering frontend VPC IP assignment and premium 40Gbps type behavior. |
test/integration/conftest.py |
Expands region capability requirements for VPC fixture and introduces IPv4-only VPC/subnet fixtures used by the new tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) | ||
|
|
||
|
|
||
| def test_nb_with_backend_only(test_linode_client, create_vpc_with_subnet): |
There was a problem hiding this comment.
Test fails locally:
in get_region return random.choice(get_regions(client, capabilities, site_type))
Is there any tag needed or custom settings?
There was a problem hiding this comment.
Yes, sometimes it happens. I added "Nodebalancers" and "VPC Dual Stack" capabilities in create_vpc fixture, to filter out valid regions only, however it still fails sometimes as some regions are not available for nodebalancers with type=premium/premium_40gb. I don't know the logic behind it and how to figure out which regions may be safely used. I asked about it on Slack and I will fix it as soon as possible
📝 Description
Integration tests for NodeBalancer Front-End IP in VPC and 40Gbps NodeBalancer-MTC
✔️ How to Test
make test-int TEST_SUITE=nodebalancer TEST_ARGS="-k test_nb_with"