Fix renewBefore spec value so they match with the inline documentation#2103
Open
christofhaerens wants to merge 1 commit intolinkerd:mainfrom
Open
Fix renewBefore spec value so they match with the inline documentation#2103christofhaerens wants to merge 1 commit intolinkerd:mainfrom
christofhaerens wants to merge 1 commit intolinkerd:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per definition the renewBefore is the value which specifies how long before expiry a certificate should be renewed. Having the duration on 8760h (24365) and the renewBefore on 7320h (24x305) will renew the certificate after 60 days (365-305). To have the certificate renewed 2 months before, the renewBefore value should be 1440h (2460). Similar for the linkerd-identity-issuer certificate.