Remove TaprootChannelSigner and musig2 crate#4481
Open
wpaulino wants to merge 3 commits intolightningdevkit:mainfrom
Open
Remove TaprootChannelSigner and musig2 crate#4481wpaulino wants to merge 3 commits intolightningdevkit:mainfrom
wpaulino wants to merge 3 commits intolightningdevkit:mainfrom
Conversation
We plan to have a single channel signer type going forward, so this is unnecessary.
Taproot support is not planned we see an increase in demand for it by users. The `musig2` crate is now owned by a third-party, and ultimately won't be used by the production version of Taproot that we end up releasing.
We plan to have a single channel signer type going forward, so this is unnecessary.
|
👋 Thanks for assigning @tankyleo as a reviewer! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4481 +/- ##
==========================================
- Coverage 85.98% 85.98% -0.01%
==========================================
Files 159 158 -1
Lines 105415 105397 -18
Branches 105415 105397 -18
==========================================
- Hits 90643 90624 -19
- Misses 12255 12258 +3
+ Partials 2517 2515 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.