Skip to content

Rustfmt reorg tests#4480

Open
wpaulino wants to merge 2 commits intolightningdevkit:mainfrom
wpaulino:rustfmt-reorg-tests
Open

Rustfmt reorg tests#4480
wpaulino wants to merge 2 commits intolightningdevkit:mainfrom
wpaulino:rustfmt-reorg-tests

Conversation

@wpaulino
Copy link
Contributor

No description provided.

@wpaulino wpaulino requested a review from TheBlueMatt March 12, 2026 18:18
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Mar 12, 2026

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.98%. Comparing base (647c3f7) to head (bce58f2).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4480   +/-   ##
=======================================
  Coverage   85.98%   85.98%           
=======================================
  Files         159      159           
  Lines      105415   105415           
  Branches   105415   105415           
=======================================
+ Hits        90643    90646    +3     
- Misses      12255    12256    +1     
+ Partials     2517     2513    -4     
Flag Coverage Δ
tests 85.98% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

check_closed_event(
&nodes[2],
1,
ClosureReason::CommitmentTxConfirmed,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull reason out?

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants