This PR addresses the out-of-memory (OOM) errors during the artifact upload stage in the CI pipeline.#4478
This PR addresses the out-of-memory (OOM) errors during the artifact upload stage in the CI pipeline.#4478Atishyy27 wants to merge 3 commits intolightningdevkit:mainfrom
Conversation
|
I've assigned @joostjager as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4478 +/- ##
=======================================
Coverage 85.98% 85.99%
=======================================
Files 159 159
Lines 105415 105415
Branches 105415 105415
=======================================
+ Hits 90643 90647 +4
- Misses 12255 12258 +3
+ Partials 2517 2510 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @TheBlueMatt @carlaKC , All the primary CI checks have passed successfully on the main runners! The OOM issue is resolved with the compression-level: 0 fix (the fuzz job passed in ~74m). The only failing check is the LDK Node Integration Tests. Looking at the logs, this seems to be a breakage caused by recent API changes in rust-lightning (PaymentForwarded event fields and splice_channel arguments) that haven't been reflected in ldk-node yet. Let me know if you want me to squash the merge commits, or if this is good to go from my end once the ldk-node repo is updated! |
TheBlueMatt
left a comment
There was a problem hiding this comment.
Please rebase your branch so that there are just commits on top of the existing LDK git tree, rather than including a merge commit.
| run: cargo semver-checks | ||
| - name: Check SemVer without any non-default features | ||
| run: cargo semver-checks --only-explicit-features | ||
| run: cargo semver-checks --only-explicit-features No newline at end of file |
There was a problem hiding this comment.
Please dont drop the EOL newline?
| - name: Checkout source code | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 |
Key Changes:
Note: I'm opening this as a Draft because jobs were stuck in the queue on my fork. I'd like to verify the fixes using the main repository's runners.