Resolve CLI API key and TLS cert from config storage dir#145
Merged
benthecarman merged 1 commit intolightningdevkit:mainfrom Mar 11, 2026
Merged
Conversation
|
👋 Thanks for assigning @benthecarman as a reviewer! |
When a custom config file is passed to ldk-server-cli, the API key and TLS certificate lookups now check the config's storage.disk.dir_path before falling back to the platform default data directory. Previously these files were only looked up in the default location, causing connection failures when using a non-default storage directory. AI tools were used in preparing this commit.
joostjager
force-pushed
the
cli-resolve-api-key-and-cert-from-storage-dir
branch
from
fded6a6 to
1ae3314
Compare
benthecarman
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a custom config file is passed to ldk-server-cli, the API key and TLS certificate lookups now check the config's storage.disk.dir_path before falling back to the platform default data directory. Previously these files were only looked up in the default location, causing connection failures when using a non-default storage directory.