Conversation
d61ad2e to
d72896e
Compare
f1db58d to
1fc87a1
Compare
40c5bdb to
c8f06de
Compare
G8XSU
left a comment
There was a problem hiding this comment.
Reviewed code apart from sql migrations.
LGTM overall.
6fb34d6 to
4854931
Compare
| use std::path::PathBuf; | ||
| use std::sync::RwLock; | ||
|
|
||
| pub(crate) fn do_read_write_remove_list_persist<K: KVStore + RefUnwindSafe>(kv_store: &K) { |
There was a problem hiding this comment.
is there another way to test this ?
I am unable to use this, if vssStore owns a runtime, it is not RefUnwindSafe somehow.
also why did we remote propTest?
There was a problem hiding this comment.
is there another way to test this ? I am unable to use this, if vssStore owns a runtime, it is not RefUnwindSafe somehow.
Hm, what is the exact error message? A quick fix may be to just impl RefUnwindSafe for VssStore {} in test.
also why did we remote propTest?
It didn't add much in this case hence I removed it when upstreaming where we probably won't add the dependency just for this. And I'd now like to keep this codebase and the one of the SqliteStore upstream as close as possible to avoid introducing any bugs when transitioning back-and-forth.
4854931 to
e5650db
Compare
0901c19 to
e42e9c1
Compare
|
Updated to 0.0.117-alpha2. |
e42e9c1 to
2522c8c
Compare
|
Updated to current upstream |
e2d5dd8 to
52f52e6
Compare
|
Switched to released 0.0.117 crate and squashed commits. |
ca4e0da to
46c4249
Compare
|
Now re-added the |
46c4249 to
102dc61
Compare
Unfortunately LDK had a regression that broke keysend/spontaneous payments. While this bug and corresponding tests are fixed upstream with 0.0.117, we also introduce test coverage for spontaneous payments here.
102dc61 to
acf76e3
Compare
|
Dropped the two pin commits since they have landed in #174 and re-added |
Based on #105.This is a draft PR which will be regularly rebased on upstream
HEADto incorporate and test the made changes.