Skip to content

fix: upgrade verify-hello-app action to v2.0.1#25

Merged
kinyoklion merged 1 commit intomainfrom
devin/1773351819-fix-ci-action-version
Mar 13, 2026
Merged

fix: upgrade verify-hello-app action to v2.0.1#25
kinyoklion merged 1 commit intomainfrom
devin/1773351819-fix-ci-action-version

Conversation

@kinyoklion
Copy link
Member

Summary

CI has been failing daily because the verify-hello-app action v1.0.1 sets the env var LAUNCHDARKLY_SERVER_KEY, but Hello.java was previously updated to read LAUNCHDARKLY_SDK_KEY. This upgrades the action to v2.0.1, which sets LAUNCHDARKLY_SDK_KEY to match.

Also fixes a missing trailing newline in ci.yml.

Review & Testing Checklist for Human

  • Verify that verify-hello-app v2.0.1 has no other breaking changes beyond the env var rename (the action inputs use_server_key, role_arn, command appear unchanged). The grep pattern in v2 changed from grep -iE "is true for this context|feature flag evaluates to true" to grep -i "feature flag evaluates to true" — confirm Hello.java's output (feature flag evaluates to) still matches.
  • Confirm CI passes on this PR (this is the real validation — the change cannot be tested locally since it depends on AWS OIDC + SSM parameters only available in CI).

Notes

The code was updated to read LAUNCHDARKLY_SDK_KEY but the CI action
v1.0.1 still set LAUNCHDARKLY_SERVER_KEY. Upgrading to v2.0.1 which
sets LAUNCHDARKLY_SDK_KEY fixes the env var mismatch.

Co-Authored-By: rlamb@launchdarkly.com <kingdewman@gmail.com>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@kinyoklion kinyoklion marked this pull request as ready for review March 12, 2026 21:46
@kinyoklion kinyoklion requested a review from a team as a code owner March 12, 2026 21:46
@kinyoklion kinyoklion merged commit 4d5383b into main Mar 13, 2026
4 checks passed
@kinyoklion kinyoklion deleted the devin/1773351819-fix-ci-action-version branch March 13, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants