fix: inheritable properties leaking in.#6
Merged
knightedcodemonkey merged 2 commits intomainfrom Mar 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent inheritable CSS properties from the app shell leaking into the preview when rendering inside a ShadowRoot, while keeping the preview host layout consistent across light DOM vs ShadowRoot modes.
Changes:
- Introduces ShadowRoot base styles (including
:host { all: initial; ... }) and prepends them to injected preview CSS when the render target is aShadowRoot. - Refactors
.preview-hostlayout properties into CSS custom properties so ShadowRoot base styles can re-apply layout after resets. - Removes the
.shadow-hint::beforetooltip caret styling and updates hover/focus selectors accordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/styles.css | Moves preview-host layout to CSS variables; removes tooltip caret (.shadow-hint::before) styles. |
| src/app.js | Prepends ShadowRoot base stylesheet to injected styles to reset inheritable leakage and restore layout via variables. |
| docs/next-steps.md | Adds roadmap items for in-browser linting, type-checking, and testing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
knightedcodemonkey
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.