fix: add contents:write permission to release workflow#331
Merged
MaorEJFrog merged 1 commit intomasterfrom Mar 22, 2026
Merged
Conversation
The release workflow needs explicit contents:write permission to force-push the v4 major version tag. Without this permission, the v4 tag is not updated when new releases are published, causing users calling @v4 to get outdated versions. This fixes the issue where v4.10.0 was released but the v4 tag was not updated, leaving users on @v4 stuck with Node 20 instead of Node 24. Relates to: JA-20235 Made-with: Cursor
roeioshry
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow needs explicit contents:write permission to force-push the v4 major version tag. Without this permission, the v4 tag is not updated when new releases are published, causing users calling @v4 to get outdated versions.
This fixes the issue where v4.10.0 was released but the v4 tag was not updated, leaving users on @v4 stuck with Node 20 instead of Node 24.
Relates to: JA-20235
npm run formatfor formatting the code before submitting the pull request.Related to #306 (comment)