Skip to content

Fix isamples_explorer: mutable variable for facet summaries#54

Merged
rdhyee merged 1 commit intoisamplesorg:mainfrom
rdhyee:main
Mar 13, 2026
Merged

Fix isamples_explorer: mutable variable for facet summaries#54
rdhyee merged 1 commit intoisamplesorg:mainfrom
rdhyee:main

Conversation

@rdhyee
Copy link
Contributor

@rdhyee rdhyee commented Mar 13, 2026

Summary

  • Bug: Explorer page completely broken — all filters, queries, and rendering failed with RuntimeError: facetSummaries is not defined
  • Root cause: facetSummariesError was assigned without being declared as mutable in OJS, which killed the facetSummaries cell and cascaded to every downstream cell
  • Fix: Added mutable facetSummariesError = null declaration and used mutable keyword when assigning

Test plan

🤖 Generated with Claude Code

OJS requires `mutable` keyword for cross-cell variable assignment.
The undeclared assignment was killing the facetSummaries cell,
cascading failures to all downstream filters and queries.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rdhyee rdhyee merged commit 955e983 into isamplesorg:main Mar 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant