feat: register Android push service in manifest and wire into plugin#384
Merged
Rosie-Kennelly-1 merged 3 commits intomainfrom Mar 10, 2026
Merged
feat: register Android push service in manifest and wire into plugin#384Rosie-Kennelly-1 merged 3 commits intomainfrom
Rosie-Kennelly-1 merged 3 commits intomainfrom
Conversation
This was referenced Mar 6, 2026
Rosie-Kennelly-1
force-pushed
the
rosie/android-expo-push-manifest
branch
5 times, most recently
from
25db688 to
4e4f18b
Compare
Base automatically changed from
rosie/android-expo-push-kotlin-generation
to
main
March 10, 2026 14:32
…nto plugin pipeline Adds manifest registration for the generated service with priority 10 and android:exported=false. Detects existing FCM services and warns instead of conflicting. Wires the Android plugin into the push notification pipeline alongside the existing iOS plugins. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The conflict detection in registerServiceInManifest only works when the competing plugin is listed after Intercom in the Expo plugins array, due to Expo's LIFO mod execution order. Added a JSDoc comment explaining this constraint and advising users to list Intercom first. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rosie-Kennelly-1
force-pushed
the
rosie/android-expo-push-manifest
branch
from
4e4f18b to
487d4d0
Compare
liutingdu
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
towards: https://github.com/intercom/intercom/issues/360467
The generated
FirebaseMessagingServicefrom the previous PR needs to be registered inAndroidManifest.xmlfor Android to route FCM events to it, and wired into the existing Expo push notification plugin pipeline.How?
Adds manifest registration with
android:priority="10"andandroid:exported="false", detects existing FCM services to avoid conflicts, and chains the Android plugin intowithPushNotifications.tsalongside the existing iOS plugins.Part 2 of 2. Stacked on:
Related:
Known limitation: FCM conflict detection is plugin-order dependent
The conflict detection (which skips Intercom's service registration when another
FirebaseMessagingServiceis found) only works when the conflicting plugin is listed after@intercom/intercom-react-nativein the Expopluginsarray.This is a constraint of Expo's
withAndroidManifestmod system, which executes callbacks in LIFO order — mods from plugins listed earlier in the array run later, so they aren't visible to Intercom's conflict check. Alternative approaches (withDangerousModpost-processing) were investigated but Expo doesn't invoke dangerous mod callbacks reliably for this use case.Impact: If another SDK's plugin is listed before Intercom and registers a
MESSAGING_EVENTservice, both services end up in the manifest. Intercom'spriority="10"means it receives all FCM messages, and non-Intercom pushes to the other SDK are silently dropped via the no-opsuper.onMessageReceived().Mitigation: Users with other FCM-handling SDKs should list
@intercom/intercom-react-nativefirst in their plugins array. This is documented in a JSDoc comment onregisterServiceInManifest.Generated with Claude Code