Skip to content

fix: update vSphere plugin documentation and configuration examples#7154

Open
NguyenHoangSon96 wants to merge 4 commits intomasterfrom
fix/invalid-config-vsphere2
Open

fix: update vSphere plugin documentation and configuration examples#7154
NguyenHoangSon96 wants to merge 4 commits intomasterfrom
fix/invalid-config-vsphere2

Conversation

@NguyenHoangSon96
Copy link
Copy Markdown
Contributor

@NguyenHoangSon96 NguyenHoangSon96 commented Mar 27, 2026

Closes 26912

  • My steps to fix:
  1. Check out the source telegraf to my local.
  2. Run go run ./cmd/telegraf config > etc/telegraf.conf command to generate etc/telegraf.conf file.
  3. Tweak the src/writeData/utils/updateTelegrafPlugins.mjs so it will get contents from my local influxdata/telegra/etc/telegraf.conf instead of the remote repository /influxdata/telegraf.
  4. Run telegraf-plugins:update command to generate new contents for md and conf files.
  5. Create this PR.

This is just a very primitive implementation of the updateTelegrafPlugins.mjs to make the script work
updateTelegrafPlugins.txt

  • Some thoughts:
  1. I don't know how these things should work exactly; this is just my assumption. If my fixes are not correct, then I will just manually remove the - at the beginning of the .conf file.
  2. If this is correct, then we should update the src/writeData/utils/README.md guidance and the src/writeData/utils/updateTelegrafPlugins.mjs script file to get contents from etc/telegraf.conf in the local repository, not the remote.
  • Before the fix, there is a - at the beginning of the file.
Screen.Recording.2025-10-22.at.09.55.53.mov
  • After I modify src/writeData/utils/updateTelegrafPlugins.mjs and run the command telegraf-plugins:update, the - at the beginning of the file disappears.
Screen.Recording.2025-10-22.at.10.01.23.mov

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@NguyenHoangSon96 NguyenHoangSon96 self-assigned this Mar 27, 2026
@NguyenHoangSon96 NguyenHoangSon96 requested review from a team as code owners March 27, 2026 03:45
@NguyenHoangSon96
Copy link
Copy Markdown
Contributor Author

@wdoconnell
Hi I have moved from this PR to this PR.
It has the latest commit from the master branch, but the "monitor-ci-tests" still persists.

Copy link
Copy Markdown
Contributor

@wdoconnell wdoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NguyenHoangSon96 It was not rebased and had the same commit sha.

I have pushed the same commit with a fresh SHA here, which is passing; feel free to open the PR from that branch. https://github.com/influxdata/ui/compare/invalid_config_vsphere3?expand=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.x] Influx generating invalid/broken config for vCenter

2 participants