fix(ci): refactor workflows to fix failing CI#20
Open
druid-infra wants to merge 1 commit intomasterfrom
Open
Conversation
- Update actions/checkout@v3 -> v4 to fix Node.js 20 deprecation - Update actions/setup-java@v3 -> v4 - Add FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env var - Add timeout-minutes to prevent hanging jobs - Change fail-fast: false for matrix jobs (don't cancel all on one failure) - Fix job name in fetch-forge (was copy-pasted as 'build-spigot') - Add better error handling and logging - Add cleanup step for failed prebuild jobs - Add wget timeouts and retries for network resilience
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes the failing CI workflows in the scrolls repository:
Issues Fixed
Key Changes
actions/checkout@v3→v4actions/setup-java@v3→v4FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: trueenv vartimeout-minutesto all jobs (prevents hanging)fail-fast: falsefor matrix jobs (one failure doesn't cancel all)Testing
Ready for review! 🚀