Fixed creation of task by using corretc parameter for cracker binary#2012
Merged
Fixed creation of task by using corretc parameter for cracker binary#2012
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes task creation in API v2 so that selecting a specific cracker binary (hashcat version) in the new UI actually persists the chosen binary, addressing issue #1996 where tasks were created with the default cracker (id 1).
Changes:
- Pass
Task::CRACKER_BINARY_ID(cracker binary id) intoTaskUtils::createTask()instead ofTask::CRACKER_BINARY_TYPE_ID.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
gpascal123
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1996