Require urllib3 >=2.6.1 to avoid broken 2.6.0 release#414
Merged
Conversation
urllib3 2.6.0 removed getheader()/getheaders() from HTTPResponse, breaking the OpenAPI-generated client. The methods were restored in 2.6.1 three days later. Bump the minimum to skip the broken version. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
brandon-wada
approved these changes
Mar 12, 2026
Collaborator
brandon-wada
left a comment
brandon-wada
left a comment
There was a problem hiding this comment.
I remember people being really upset about 2.6.0. Looks good assuming tests pass
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urllib3 2.6.0 removed getheader()/getheaders() from HTTPResponse, breaking the OpenAPI-generated client. The methods were restored in 2.6.1 three days later. Bump the minimum to skip the broken version.
To remove the deprecated getheader()/getheaders(), we'll need to bump the version of our generator. This introduced some more issues when I tried it, so leaving that for another time.