[DRAFT] feat(firestore): pipeline subequeries#16470
Draft
daniel-sanche wants to merge 6 commits intomainfrom
Draft
[DRAFT] feat(firestore): pipeline subequeries#16470daniel-sanche wants to merge 6 commits intomainfrom
daniel-sanche wants to merge 6 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for subqueries and variables within Firestore pipelines. Key additions include methods to convert pipelines into array or scalar expressions, a define stage for binding variables, and a subcollection source for relative path queries. New expression types like Variable and CurrentDocument were also implemented alongside corresponding system tests. Feedback was provided to add a type hint to the _PipelineValueExpression constructor to improve type safety and code clarity.
packages/google-cloud-firestore/google/cloud/firestore_v1/pipeline_expressions.py
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP