test: Add DBAPI 2.0 compliance test suite#16158
test: Add DBAPI 2.0 compliance test suite#16158bhatt4982 wants to merge 2 commits intodbapi-driver-1from
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the testing infrastructure by introducing a robust DBAPI 2.0 compliance test suite. The new tests are designed to verify that the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a DBAPI 2.0 compliance test suite, which is a great addition for ensuring driver compatibility. The changes include a new nox session for running these tests, a base test class, a SQL factory for generating test data, and helper utilities. My review focuses on improving the robustness and correctness of the new test infrastructure. I've identified a critical issue in the nox configuration that would prevent the tests from running correctly, and a couple of medium-severity issues related to code robustness and error handling in the test helpers and base class.
| except Exception: | ||
| pass |
There was a problem hiding this comment.
…, SQL factory, helper utilities, and nox integration.
fe0fe25 to
c65ad37
Compare
…d rollback operations
test: Add DBAPI 2.0 compliance test suite including a base test class, SQL factory, helper utilities, and nox integration.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #16120 🦕