chore: bump minimum version of google-cloud-os-config and google-cloud-kms#2586
chore: bump minimum version of google-cloud-os-config and google-cloud-kms#2586
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the minimum required versions for the google-cloud-kms and google-cloud-os-config client libraries. This change is crucial for ensuring that projects using these libraries can successfully integrate with google-api-core version 2.x, resolving previous dependency conflicts and improving overall library compatibility. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request bumps the minimum required versions for google-cloud-kms to 2.4.1 and google-cloud-os-config to 1.3.1. These changes, made in the _pypi_packages.j2 template, are necessary to resolve dependency conflicts and enable support for google-api-core version 2.x. The update is correctly applied to the central template, ensuring that newly generated client libraries will have the correct dependency constraints. The change appears correct and follows the repository's conventions.
Similar to #2582 to bump the minimum to versions that allow google-api-core 2.x
https://github.com/googleapis/python-kms/releases/tag/v2.4.1
https://github.com/googleapis/python-os-config/releases/tag/v1.3.1