[codegen] Test and document codegen for FromZeros#3114
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces benchmark tests and documentation generation for methods within the FromZeros trait. New benchmark files are added for methods such as zero, new_zeroed, new_box_zeroed, and new_vec_zeroed. Correspondingly, src/lib.rs is updated with #[doc = codegen_section!(...)] attributes on these methods to incorporate the benchmark results into the documentation. The changes appear to follow the existing patterns for codegen documentation within the project. I have reviewed the changes and found no issues.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3114 +/- ##
=======================================
Coverage 91.87% 91.87%
=======================================
Files 20 20
Lines 6057 6057
=======================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jswrenn
force-pushed
the
Gea71a24b6b02a2d552b4af3e0980e71a50ab8f52
branch
from
7c3d2c0 to
a3e3507
Compare
jswrenn
force-pushed
the
G09ea59a47925616837b859b2c3cdf7f0f919232e
branch
from
355fd79 to
8679ffd
Compare
jswrenn
force-pushed
the
Gea71a24b6b02a2d552b4af3e0980e71a50ab8f52
branch
from
a3e3507 to
99d63b7
Compare
jswrenn
force-pushed
the
G09ea59a47925616837b859b2c3cdf7f0f919232e
branch
from
8679ffd to
7577a0f
Compare
jswrenn
force-pushed
the
Gea71a24b6b02a2d552b4af3e0980e71a50ab8f52
branch
from
99d63b7 to
24287c9
Compare
jswrenn
force-pushed
the
G09ea59a47925616837b859b2c3cdf7f0f919232e
branch
from
7577a0f to
f811111
Compare
jswrenn
force-pushed
the
Gea71a24b6b02a2d552b4af3e0980e71a50ab8f52
branch
from
24287c9 to
955cf5c
Compare
jswrenn
force-pushed
the
G09ea59a47925616837b859b2c3cdf7f0f919232e
branch
from
f811111 to
c2cc179
Compare
jswrenn
force-pushed
the
Gea71a24b6b02a2d552b4af3e0980e71a50ab8f52
branch
2 times, most recently
from
9692318 to
c184959
Compare
|
@joshlf any idea what's going on with failing CI here? |
Yeah, it's a silly and thankfully transient bug I need to fix. Just rebase on |
Vendors `regex` to normalize labels. Makes progress towards #3079. gherrit-pr-id: Gea71a24b6b02a2d552b4af3e0980e71a50ab8f52
jswrenn
force-pushed
the
Gea71a24b6b02a2d552b4af3e0980e71a50ab8f52
branch
from
c184959 to
01dd996
Compare
3 participants
Vendors
regexto normalize labels.Makes progress towards #3079.
FromZeros#3114Latest Update: v19 — Compare vs v18
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gea71a24b6b02a2d552b4af3e0980e71a50ab8f52 && git checkout -b pr-Gea71a24b6b02a2d552b4af3e0980e71a50ab8f52 FETCH_HEADCheckout
git fetch origin refs/heads/Gea71a24b6b02a2d552b4af3e0980e71a50ab8f52 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gea71a24b6b02a2d552b4af3e0980e71a50ab8f52 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.