feat: asymmetric visibility support (PHP 8.4+)#1219
Draft
Conversation
Add parsing support for PHP 8.4 asymmetric visibility modifiers on class properties and constructor promotion parameters. - Parse `public private(set)`, `protected private(set)`, `private(set)`, `protected(set)` modifiers in class body via `read_member_flags` - Parse asymmetric visibility on constructor promoted parameters via `read_promoted` in function.js - Add `visibilitySet` field to `Declaration` and `PropertyStatement` AST nodes - Add `flagsSet` field to `Parameter` AST node - Update `types.d.ts` with new fields - All (set) parsing is gated behind `version >= 804` Co-authored-by: Thomas Genin <664857+genintho@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1148
Add parsing support for PHP 8.4 asymmetric visibility modifiers on class properties and constructor promotion parameters.
public private(set),protected private(set),private(set),protected(set)modifiers in class bodyread_promotedin function.jsvisibilitySetfield toDeclarationandPropertyStatementAST nodesflagsSetfield toParameterAST node