Modernize: ESM, Node 24, latest deps, security fix#105
Merged
Conversation
- Mask private key via core.setSecret() to prevent leaking in error logs - Convert to native ESM (type: module, nodenext) - Upgrade action runtime to node24 - Upgrade all deps to latest (octokit 8/22, actions/core 3, TS 5.9, ESLint 10, Jest 30, Prettier 3) - Migrate ESLint to flat config, remove redundant rules covered by recommendedTypeChecked - Consolidate config: jest/prettier inline in package.json, remove husky/lint-staged - Add test suite covering secret masking, scoping, error handling - Remove unused deps (js-yaml, eslint-config-sentry, eslint-plugin-github) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
joshuarli
commented
Mar 19, 2026
| async function run(): Promise<void> { | ||
| try { | ||
| const privateKey: string = core.getInput('private_key'); | ||
| core.setSecret(privateKey); |
Member
Author
There was a problem hiding this comment.
this is the core fix, the rest is just upgrading to node 24 + ESM + deps + consolidation of excess config files lol
joshuarli
commented
Mar 19, 2026
| "@actions/core": "^1.10.1", | ||
| "@octokit/auth-app": "^7.1.1", | ||
| "@octokit/rest": "^20.0.2" | ||
| "@actions/core": "^3.0.0", |
Member
Author
There was a problem hiding this comment.
thhis is good and long overdue
hubertdeng123
approved these changes
Mar 19, 2026
evanpurkhiser
approved these changes
Mar 19, 2026
joshuarli
added a commit
to getsentry/sentry
that referenced
this pull request
Mar 19, 2026
comes with a security fix and also upgrades to node24: getsentry/action-github-app-token#105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core.setSecret()immediately after reading — prevents leaking in error logs🤖 Generated with Claude Code