[Repo Assist] Fix Wilcoxon signed-rank test: incorrect rank multiplication in tie correction#358
Draft
github-actions[bot] wants to merge 2 commits intodeveloperfrom
Conversation
The tieCorrection function incorrectly multiplied the correction term by the rank value (i) when tie group size j > 2. The standard formula for the Wilcoxon tie correction is sum((t^3 - t) / 48) where t is the count of tied observations — the rank plays no role. This bug only affected datasets where at least one tie group had 3 or more equal values; pairs (j=2) were handled correctly by a special case. Closes #347 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated PR from Repo Assist.
Closes #347
Root Cause
The
tieCorrectionfunction inTesting/Wilcoxon.fswas multiplying the correction term by the rank valueiwhen a tie group had size > 2:The standard Wilcoxon signed-rank tie correction formula is:
where$t_k$ is the number of observations in each tied group — the rank value plays no role. The special case for
j = 2.0happened to be correct (because it skipped the multiplication), but any tie group with 3+ equal values produced an inflated correction term, leading to incorrect z-statistics and p-values.Fix
✅ Build: succeeded
✅ Tests: 8/8 passed (6 existing + 2 new)