Skip to content

WIP: Kolmogorov-Smirnov test#177

Open
omaus wants to merge 2 commits intofslaborg:developerfrom
omaus:KolmogorovSmirnov
Open

WIP: Kolmogorov-Smirnov test#177
omaus wants to merge 2 commits intofslaborg:developerfrom
omaus:KolmogorovSmirnov

Conversation

@omaus
Copy link
Member

@omaus omaus commented Jan 28, 2022

Thank you for contributing to FSharp.Stats. Please take the time to tell us a bit more about your PR.

Closes #176

Please list the changes introduced in this PR

  • Introduces the Kolmogorov-Smirnov goodness-of-fit test

Description

Added a part of the KS GoF test.
IMPORTANT: It cannot be finished since the Kolmogorov distribution is not implemented right now which is needed to create a full test (with p-values). Atm., only the test statistics can be calculated.
Unit tests are also not added (since the test is not complete).
KS Two-sample test is missing, too.

Don't merge this PR until at least the GoF test is complete and the Kolmogorov distribution is added, as well as unit tests are implemented.

  • The project builds without problems on your machine
  • Added unit tests regarding the added features

@github-actions
Copy link

🤖 This is an automated nudge from Repo Assist.

Hi @omaus! This PR has been open since January 2022. The description notes it's waiting on the Kolmogorov distribution (tracked in #89) and unit tests before it can be merged.

Is this something you'd still like to complete, or would you prefer to close it for now (it could always be reopened later)? If you'd like help getting it across the finish line, feel free to say so — I'm happy to assist where I can. No pressure either way!

Generated by Repo Assist ·

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@d88ca0e8ee2b080fcba4490ac5b657c98a0eb26b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Kolmogorov-Smirnov test

1 participant