docs: expand CONTRIBUTING.md with human-oriented guidelines from AGENTS.md#239
docs: expand CONTRIBUTING.md with human-oriented guidelines from AGENTS.md#239
Conversation
…TS.md Agent-Logs-Url: https://github.com/forwardsoftware/react-auth/sessions/ce6f24e2-e49b-40d5-8d3f-d8b5daddba19 Co-authored-by: panz3r <1754457+panz3r@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Expands CONTRIBUTING.md by porting and rephrasing the previously agent-focused development guidance from AGENTS.md into a human-oriented contributor guide, covering repo workflows, architecture, testing, style, CI/CD, and security expectations.
Changes:
- Added pnpm workspace setup commands and per-package workflows (build/test/lint/clean).
- Documented monorepo architecture (packages, examples) and detailed checklists for core fixes and adapter authoring.
- Added sections for testing conventions, code style, CI/CD + release process, Conventional Commits, PR checklist, pitfalls, and security rules.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot can we also review README.md to avoid duplicating too much information and instead prefer referencing CONTRIBUTING.md Also consider mentioning that README.md, CONTRIBUTING.md and AGENTS.md needs to be updated when implementing new adapters (since they contain references to packages) |
Agent-Logs-Url: https://github.com/forwardsoftware/react-auth/sessions/fe2faef1-c02d-41f9-ad72-386515262af9 Co-authored-by: panz3r <1754457+panz3r@users.noreply.github.com>
Done in ec74e47:
|
|
@copilot can you please review and apply fixes suggested in PR review? |
All four PR review suggestions were already applied in ec74e47:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CONTRIBUTING.mdwas sparse — mostly issue/PR process boilerplate — whileAGENTS.mdhad comprehensive development guidelines written exclusively for AI agents. This PR adapts and ports those guidelines intoCONTRIBUTING.mdfor human contributors, and reduces duplication betweenREADME.mdandCONTRIBUTING.md.Affected Package(s)
@forward-software/react-auth(lib)@forward-software/react-auth-google(packages/google-signin)Related Issue(s)
Motivation
AGENTS.mdcontains rich development context (architecture, code style, test conventions, adapter authoring checklist, security rules) that is equally valuable to human contributors but was inaccessible because the file is scoped to AI agents.CONTRIBUTING.mdonly covered bug reports and the PR submission flow. Additionally,README.mdcontained overlapping setup and structure information that is now better kept inCONTRIBUTING.md.Description of Changes
pnpmworkspace commands for install, build, test, lint (global and per-package)CONTRIBUTING.mdandAGENTS.mdas files to update when adding a new packagertl.cleanuprule scoped to tests that use@testing-library/react), test file template, adapter-specific patternsx.y.0/x.y.zinstead of misleading0.x.0/0.0.x) and scoped examplesAGENTS.md— "Update documentation" step updated to also listCONTRIBUTING.mdandAGENTS.mdas files to update when adding a new packageREADME.md— simplifiedProject Structuresection (condensed folder tree + link toCONTRIBUTING.md#project-architecture) and removed the standaloneBuilding/Testingsubsections in favour of a reference toCONTRIBUTING.md#repository-setup, eliminating duplicationBreaking Changes
None
How to Test
Vitest) and build steps pass successfully on this PR.pnpm installto install dependencies.pnpm --filter <affected-package> testto run tests for the affected package.pnpm --filter <affected-package> buildto verify the build succeeds.pnpm --filter <affected-package> lintto check for linting errors.Checklist
Notes for Reviewers
Documentation-only change — no source or test files modified. Key decisions:
README.mdretains a brief project structure overview but delegates detailed architecture and setup instructions toCONTRIBUTING.md; bothCONTRIBUTING.mdandAGENTS.mdnow cross-reference each other in the adapter authoring checklist so neither document drifts out of sync when new packages are added.Original prompt
⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.