release: Add the scripts to publish to az marketplace#3812
Open
sayanchowdhury wants to merge 1 commit intomainfrom
Open
release: Add the scripts to publish to az marketplace#3812sayanchowdhury wants to merge 1 commit intomainfrom
sayanchowdhury wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
sayanchowdhury
requested a deployment
to
development
GitHub Actions
Waiting
krnowak
reviewed
Mar 10, 2026
Comment on lines
+6
to
+14
| function release_azure_marketplace() { | ||
| # Run a subshell, so the traps, environment changes and global | ||
| # variables are not spilled into the caller. | ||
| ( | ||
| set -euo pipefail | ||
|
|
||
| _release_azure_marketplace_impl "${@}" | ||
| ) | ||
| } |
Member
There was a problem hiding this comment.
It's probably something you copied from ci-automation, but you could make it simpler dropping the toplevel braces:
Suggested change
| function release_azure_marketplace() { | |
| # Run a subshell, so the traps, environment changes and global | |
| # variables are not spilled into the caller. | |
| ( | |
| set -euo pipefail | |
| _release_azure_marketplace_impl "${@}" | |
| ) | |
| } | |
| # Run a subshell, so the traps, environment changes and global | |
| # variables are not spilled into the caller. | |
| function release_azure_marketplace() ( | |
| set -euo pipefail | |
| _release_azure_marketplace_impl "${@}" | |
| ) |
| source sdk_container/.repo/manifests/version.txt | ||
|
|
||
| local docker_vernum="" | ||
| docker_vernum="$(vernum_to_docker_image_version "${vernum}")" |
Member
There was a problem hiding this comment.
Suggested change
| docker_vernum="$(vernum_to_docker_image_version "${vernum}")" | |
| docker_vernum=$(vernum_to_docker_image_version "${vernum}") |
| -e AZ_SECRET_VALUE="${AZ_SECRET_VALUE}" \ | ||
| -v "${PWD}"/ci-automation/release/azure_marketplace_publish.py:/app/azure_marketplace_publish.py \ | ||
| -w /app \ | ||
| ghcr.io/astral-sh/uv:alpine \ |
Member
There was a problem hiding this comment.
Should this be something to mirror on our ghcr?
Comment on lines
+262
to
+263
| if not args.test_mode and plan not in ("alpha", "beta", "stable", "lts2022", "lts2023", "lts2024"): | ||
| logging.error("plan value should be either alpha, beta, stable, lts2024, lts2023 or lts2022") |
Member
There was a problem hiding this comment.
Probably would be nicer to get the lts list from the lts-info file.
| logging.error("Required: AZ_TENANT_ID, AZ_CLIENT_ID, AZ_SECRET_VALUE") | ||
| return | ||
|
|
||
| access_token = generate_partner_center_token(tenant_id, client_id, secret_value) |
Member
There was a problem hiding this comment.
Does this generate a new access token every time or returns the same thing? If the former, should we destroy those after publishing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Azure marketplace publishing to Jenkins pipeline to load the items into draft.
To be merged with https://github.com/flatcar/jenkins-os/pull/417