Skip to content

[1979] Add node creation tools for time slice and snapshot#2104

Open
gcoutable wants to merge 1 commit intomainfrom
gco/enh/graphical-node-portionkind-node-tool
Open

[1979] Add node creation tools for time slice and snapshot#2104
gcoutable wants to merge 1 commit intomainfrom
gco/enh/graphical-node-portionkind-node-tool

Conversation

@gcoutable
Copy link
Copy Markdown
Member

@gcoutable gcoutable commented Mar 27, 2026

Bug: #1979
Signed-off-by: Guillaume Coutable guillaume.coutable@obeo.fr

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@gcoutable gcoutable added this to the 2026.5.0 milestone Mar 27, 2026
@gcoutable gcoutable force-pushed the gco/enh/graphical-node-portionkind-node-tool branch from 6bff03f to b64cd23 Compare March 27, 2026 13:46
@gcoutable gcoutable linked an issue Mar 27, 2026 that may be closed by this pull request
String elementsExpression = SUPPORTED_PORTION_KIND_ELEMENTS.stream().map(SysMLMetamodelHelper::buildQualifiedName).collect(Collectors.joining(",", "aql:Sequence{", "}"));
return this.diagramBuilderHelper.newSelectionDialogTreeDescription()
.elementsExpression(elementsExpression)
.isSelectableExpression("aql:true")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AQLConstants.AQL_TRUE

String elementsExpression = SUPPORTED_PORTION_KIND_ELEMENTS.stream().map(SysMLMetamodelHelper::buildQualifiedName).collect(Collectors.joining(",", "aql:Sequence{", "}"));
return this.diagramBuilderHelper.newSelectionDialogTreeDescription()
.elementsExpression(elementsExpression)
.isSelectableExpression("aql:true")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AQLConstants.AQL_TRUE

@AxelRICHARD
Copy link
Copy Markdown
Member

I will fix the small comments, rebase and merge the PR. Thank you! 👍

Bug: #1979
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>
@AxelRICHARD AxelRICHARD force-pushed the gco/enh/graphical-node-portionkind-node-tool branch from b64cd23 to 84b1db2 Compare March 27, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a tool to create a "timeslice" element

2 participants