Move requirements file into seperate one#130
Move requirements file into seperate one#130MaximilianSoerenPollak wants to merge 3 commits intoeclipse-score:mainfrom
Conversation
Having all reqs inside python_basics is breaking other modules. These requirements are only needed for testing, and should therefore be moved somewhere more appropriate where they do not break consumers of python_basics
Tests are passing |
MaximilianSoerenPollak
requested review from
AlexanderLanin,
PiotrKorkus,
dcalavrezo-qorix and
ramceb
| src = "//:requirements.in", | ||
| requirements_txt = "//:requirements.txt", |
There was a problem hiding this comment.
shouldn't it be without // to make sure we are using files from this directory and not something aliased / published to the root?
There was a problem hiding this comment.
It's always from module root (so the earliest MODULE.bazel file it finds).
So this can only mean the requirements.txt inside the test folder here.
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| compile_pip_requirements( |
There was a problem hiding this comment.
also how does it work when compiled requirements are not parsed by pip and passed as deps to any of the targets in this file?
Looks like adding only compile_pip_requirements with tag=manual has no impact, right?
There was a problem hiding this comment.
Yes it does seem that it has 0 impact as it's nowhere used in the dependencies.
And according to that it would be quiet useless.
But that isn't for me to fix, as I don't maintain this module and don't want to delete things that might be required later.
That's why I have only moved it to an appropriate location at the moment.
2 participants
Having all reqs inside python_basics is breaking other modules. These requirements are only needed for testing, and should therefore be moved somewhere more appropriate where they do not break consumers of python_basics.