Conversation
kgraeper
requested review from
AlexanderLanin,
FScholPer,
MaximilianSoerenPollak,
PiotrKorkus,
antonkri,
dcalavrezo-qorix,
lurtz,
nradakovic,
opajonk and
pawelrutkaq
as code owners
|
The created documentation from the pull request is available at: docu-html |
PiotrKorkus
left a comment
PiotrKorkus
left a comment
There was a problem hiding this comment.
how are secrets handled? Main entrance point to the workflows is now triggered on pull_request I think it wont give access to the secrets in downstream jobs.
scripts/integration_test.py
Outdated
|
|
||
| try: | ||
| old_modules = load_known_good(Path("known_good.json")).modules if Path("known_good.json").exists() else {} | ||
| old_modules = _flatten_modules(load_known_good(Path("known_good.json")).modules) if Path("known_good.json").exists() else {} |
There was a problem hiding this comment.
is this path corerct? there is no known_good.json in scripts/
Also the amout of operations in one line is quite big, maybe its worth splitting now?
There was a problem hiding this comment.
dont change formatting of bazel, it needs to match with expected formatting of starlark
| old_hash = mod.hash | ||
| if latest != old_hash: | ||
| old_version = mod.version | ||
| mod.hash = latest | ||
| mod.version = None # Clear version when hash changes | ||
| if old_version: | ||
| print(f"{mod.name}: {old_version} -> {latest[:8]} (branch {branch})") | ||
| else: | ||
| print(f"{mod.name}: {old_hash[:8]} -> {latest[:8]} (branch {branch})") | ||
| else: | ||
| print(f"{mod.name}: {old_hash[:8]} -> {latest[:8]} (branch {branch})") | ||
| else: | ||
| print(f"{mod.name}: {old_hash[:8]} (no update)") | ||
| except Exception as e: # noqa: BLE001 | ||
| failures += 1 | ||
| print(f"ERROR {mod.name}: {e}", file=sys.stderr) | ||
| if args.fail_fast: | ||
| break | ||
| print(f"{mod.name}: {old_hash[:8]} (no update)") |
There was a problem hiding this comment.
new method candidate? compare_versions or smth?
There was a problem hiding this comment.
Im not a fan of using very different names for the same job e.g. utest and integratio testing same time?
kgraeper
force-pushed
the
feature/test-known-good-update-public
branch
from
8bb8280 to
26c3c4e
Compare
pawelrutkaq
left a comment
pawelrutkaq
left a comment
There was a problem hiding this comment.
Looks better than bforem still please get rid of most of the "integration test" name and describe what they really do. The only step integration test is once we run FIT. Also, not all jobs are run yet.
| echo "::group::update bazel_common/score_modules_*.MODULE.bazel" | ||
| scripts/known_good/update_module_from_known_good.py --known known_good.updated.json --output-dir-modules bazel_common | ||
| cat bazel_common/score_modules_*.MODULE.bazel | ||
| echo "::endgroup::" |
There was a problem hiding this comment.
shall this be in repo action so its not copy pasted everywhere ?
| run: echo "separate doc workflow" | ||
| build_and_test_autosd: | ||
| name: build_and_test_autosd | ||
| needs: docs |
There was a problem hiding this comment.
al builds ned only preparation, nothing else
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
| # Nightly / manual integration tests: updates all modules to latest HEAD on their branch. | ||
| name: Integration Tests (Nightly) |
There was a problem hiding this comment.
Auto update dependencies - integration test mean nothing.
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '30 2 * * *' # Every night at 02:30 UTC on main-etas branch |
| # ******************************************************************************* | ||
| # Workflow configuration for S-CORE CI - Bazel Build & Test baselibs | ||
| # This workflow runs Bazel build and test when triggered by specific pull request events. | ||
| name: Integration Tests (PR) |
There was a problem hiding this comment.
Different name really.
| name: Integration Tests (PR) | ||
| on: | ||
| workflow_dispatch: | ||
| pull_request_target: |
There was a problem hiding this comment.
here we have problem. once we do it it means all release branches will never work. We need to seperate targeta thta need pr target into separate workflows and call them differently. This is hell complicated, maybe we shall do it after this PR.
| @@ -300,14 +300,24 @@ def main(): | |||
| log_dir.mkdir(parents=True, exist_ok=True) | |||
There was a problem hiding this comment.
we can remove this one. Qe have all we need currenlty in quality runner and in workflows.
3 participants
No description provided.