Draft
Conversation
GIT_ORIGIN_SPP_REV_ID: eea3ca95164219105a71b5aec99e5e7ff475cbeb
GIT_ORIGIN_SPP_REV_ID: 873163b2459e876c032113dfb0487b4b5f758682
GIT_ORIGIN_SPP_REV_ID: f49d1e11d6bb7d7a9592573e75afbf562e2f5cb9
GIT_ORIGIN_SPP_REV_ID: 44eb19227ebfd0494e6c8a946fb03e56cb1fbdda
Issue: SWP-187609 GIT_ORIGIN_SPP_REV_ID: 1c92eee0be47b41ee0f759e427df88ac28f2745c
fix line coverage for operator != Issue: SWP-187874 GIT_ORIGIN_SPP_REV_ID: 2427ba0c148967ff008afffed21f2a8afcb52b0c
- GTL L3 Coverity warnings fix Issue: SWP-187527 GIT_ORIGIN_SPP_REV_ID: ea7ac81edc8066ab17499c29053caf1f09fc4542
These are the regular compiler features that should be used by any component that wants to claim to have good check on compiler warnings. To not repeat the variable in every component, we put it in a single place. Because safecpp is a place to have tools to have safe code in C++, this is a good location. Issue: SWP-177717 GIT_ORIGIN_SPP_REV_ID: cb04e42a19a351ae38b05d030a55124fdc422968
This reverts commit e0049ee4f3ffbaa89e03e9aaba305536c0d3cd1d. GIT_ORIGIN_SPP_REV_ID: 5775aedf25c50a4ad7e05dcfa91d08637553343a
Issue: SWP-177717 GIT_ORIGIN_SPP_REV_ID: 2a68a8ee2aedaca21a50918a9551a4d69df3739f
Issue: SWP-177717 GIT_ORIGIN_SPP_REV_ID: 43504c5638b7749554fc41ccf033473eb6aa1afa
lib_memory: region bounds fix line coverage for operator != Issue: SWP-187874 Reviewed-by: janschlosser <Jan.Schlosser@bmw.de> Reviewed-by: brendanbeemery GIT_ORIGIN_SPP_REV_ID: 99d5872a22bbba00b05f4ce2c6847738a16ba1a7
Issue: SWP-177717 GIT_ORIGIN_SPP_REV_ID: f83a3fcf41f771fb078a7914d5b6ddbd8a4ed264
copybara: Add rules for LoLa and support different modules Issue: SWP-177717 Reviewed-by: Łukasz Tekieli <Lukasz.Tekieli@bmw.de> GIT_ORIGIN_SPP_REV_ID: 6189a4a503c3d26a0ece08d51b8ab7a37c1444de
memory/shared: Use central variable for compiler warnings Issue: SWP-177717 Depends-On: #372 Reviewed-by: brendanbeemery GIT_ORIGIN_SPP_REV_ID: cbf8e7faebc69430b90716bad7ce818a9ab18e4a
Every function defined in an anonymous namespace, or static function with internal linkage, or private member function shall be used. Issue: SWP-187976 GIT_ORIGIN_SPP_REV_ID: b7841fcf9c23f2ff030ed4b1c3f0e926d1b94a46
lib/filesystem: suppress autosar a0-1-1 A project shall not contain instances of non-volatile variables being given values that are not subsequently used Issue: SWP-187976 Reviewed-by: janschlosser <Jan.Schlosser@bmw.de> GIT_ORIGIN_SPP_REV_ID: 68b68bd30a59f90e75d0fcecf74ce2e3b381c2de
In order to use everywhere the same targets, we depend on //thirdparty/googletest. This will enable also a better CopyBara functionality. Issue: SWP-171449 GIT_ORIGIN_SPP_REV_ID: 53d75c44faae0c9f19d7293f33600aa028e37866
MISRA rule 6.7.1 prohibits the use of non-const local static variables. Through the macro this violation spreads over all code which uses STRUCT_VISITABLE. Issue: DCS-12481 GIT_ORIGIN_SPP_REV_ID: 7a7e5c5968f315fd18ece9bfadf8c22c0a77df1a
Issue: SWP-176457 GIT_ORIGIN_SPP_REV_ID: e9a15e7fab54e3acccc82492d66b909215dbb1a4
Issue: SWP-187295 GIT_ORIGIN_SPP_REV_ID: 582d505a2640714d11ef4d0551f691184e9ae92e
- add target to build file - fix test file clang tidy warnings Issue: SWP-187874 GIT_ORIGIN_SPP_REV_ID: eb08d1cd8e88c2eb461c58351e95929cd23adde4
memory region bounds: increase coverage add target to build file fix test file clang tidy warnings Issue: SWP-187874 Reviewed-by: brendanbeemery GIT_ORIGIN_SPP_REV_ID: 8af501b29fd51d90dfd32ede0443f67c5c0920b2
An if ( condition ) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement. Issue: SWP-187976 GIT_ORIGIN_SPP_REV_ID: 63f06062e2d5d86474ba181386a897c5d6b6aac0
lib/result: suppress autosar m6-4-1 An if ( condition ) construct shall be followed by a compound statement. The else keyword shall be followed by either a compound statement, or another if statement. Issue: SWP-187976 Reviewed-by: George Dadunashvili <george.dadunashvili@bmw.de> Reviewed-by: janschlosser <Jan.Schlosser@bmw.de> GIT_ORIGIN_SPP_REV_ID: 18788344e21c15defeb402714b0d471cf7aaf87d
- added constructor call with size 0 and initial value - make test ConstructTrivialEmpty more descriptive Issue: SWP-187874 GIT_ORIGIN_SPP_REV_ID: dff85a141e9e6f7c4ce9df99b9712899a83bf88a
containers: fix coverage dynamic array added constructor call with size 0 and initial value Issue: SWP-187874 Reviewed-by: brendanbeemery Reviewed-by: Xavier Bonaventura (JC-51) <Xavier.Bonaventura@bmw.de> GIT_ORIGIN_SPP_REV_ID: 9f703efbd37f2313ea17bf2e1f860739930058ec
Issue: SWP-187874 GIT_ORIGIN_SPP_REV_ID: b0d01653bd84123303dbb0ff91e6f1b30c3474ae
Issue: SWP-187874 GIT_ORIGIN_SPP_REV_ID: f8269381fc8dccb16576edd1a07f0c62bec87233
GIT_ORIGIN_SPP_REV_ID: 249a44fa95621577b02427e8845f1f3682ebad29
GIT_ORIGIN_SPP_REV_ID: 694737b79a1b2e7693e50cd9be1543108e2bd7ad
GIT_ORIGIN_SPP_REV_ID: 530ed3230c7104ca97470d218f28ea11e5273f31
- Restrict MemoryResourceProxy access via private method and friend allocator - Deprecate raw pointer PolymorphicOffsetPtrAllocator constructor - Remove deprecated raw pointer constructor from PolymorphicOffsetPtrAllocator - Update PUML diagrams to reflect new allocator API - Fix allocator test helper to use new ManagedMemoryResource constructor GIT_ORIGIN_SPP_REV_ID: d6cbec5629b12c5a3adf9c7a85971a56ec6052ee
Some accessibility specifiers for the ManagedMemoryResource do not reflect the current state of implementation. GIT_ORIGIN_SPP_REV_ID: 2ce31f5d31b76058115a7caba104f6a88201be10
- project sensitve text transformations moved GIT_ORIGIN_SPP_REV_ID: aa2000a352b30bf9283ea522b521b1a475eb9bba
The shell script for generating svgs from puml files is part of s-core, thus it requires the copyright header. GIT_ORIGIN_SPP_REV_ID: dd7e2d77d01e7488a212b7f95a70dbfe32ff3e38
GIT_ORIGIN_SPP_REV_ID: 66e3e1c6192d74ed9bed0188be11bb28a6639629
- Fix SharedMemoryResource::do_allocate to log allocation_start_address instead of new_address_aligned (which is nullptr on failure) - Add test AllocationFailureLogsCorrectStartAddress GIT_ORIGIN_SPP_REV_ID: 05b21608ad58d242ddf1e0a27363f21bdfb40607
Closes eclipse-score/baselibs#108 GIT_ORIGIN_SPP_REV_ID: d86e970f58761aadbf73b4b92d0a1073f8270189
Improve error message in case there is not enough memory to allocate GIT_ORIGIN_SPP_REV_ID: b80c14845881afbe682e86f75396a70d9e7d37d3
GIT_ORIGIN_SPP_REV_ID: fbe2b0c49ac80535606a072e31db176ab46f3a27
Preserves full git history (145 commits) via git filter-repo extraction. score/memory remains dependent on @score_baselibs//score/os/*.
…memory 178 references updated across BUILD files and .bazelrc. score/os and other baselibs deps left pointing at @score_baselibs.
- boost.container is required by score/memory/shared:map - local_path_override for score_baselibs needed until upstream merges interprocess_mutex visibility fix
- Remove atomic_indirector implementation and tests - Remove atomic_mock utilities - Remove i_atomic interface
- Remove split_string_view implementation and tests - Remove string_comparison_adaptor implementation and tests - Remove string_literal header
- Update include paths from score_baselibs references - Adjust BUILD dependencies - Update namespace references in bindings and mocking
KrishaDeshkool
force-pushed
the
memory-migration
branch
from
dea34b4 to
82eb196
Compare
Contributor
Author
|
This does not work yet since we have local repo mapping until we get the visibility changes into the baselibs |
…mr_ring_buffer targets These targets are duplicates of the canonical ones in score-baselibs. Remove the cc_library and test targets from communication's score/memory/BUILD and delete the 8 associated source/test files. Tests remain in baselibs where the sources live.
Replace //score/memory:data_type_size_info with the canonical @score_baselibs//score/memory:data_type_size_info across all consumers in score/memory/shared and score/mw/com.
…iases to @score_baselibs Convert 16 cc_library targets to aliases pointing at @score_baselibs//score/memory/shared: pointer_arithmetic_util, i_shared_memory_resource, managed_memory_resource, memory_region_map, memory_region_bounds, memory_resource_registry, memory_resource_proxy, offset_ptr, offset_ptr_bounds_check, polymorphic_offset_ptr_allocator, map, string, vector, types, user_permission, shared_memory_error Remove 5 pure-primitive test targets (duplicated in baselibs): memory_region_bounds_test, shared_memory_error_test, memory_resource_registry_test, pointer_arithmetic_util_precondition_violation_test, pointer_arithmetic_util_calculate_aligned_size_test Delete 29 primitive source files and 5 redundant test files. Fix short include paths in remaining test files to use full paths for headers now resolved from external @score_baselibs. Communication-only targets (shared_memory_resource, shared_memory_factory, lock_file, new_delete_delegate_resource, mocks, test resources) remain as cc_library with their source files.
- Add core shared memory types: managed_memory_resource, offset_ptr, memory_region_bounds, memory_region_map, memory_resource_proxy/registry - Add allocation algorithm, pointer arithmetic utils - Add shared memory containers: string, vector, map - Add shared_memory_error, i_shared_memory_resource - Add deprecated atomic redirect headers - Update BUILD files and fake implementations
Update score/memory/shared/BUILD, fake/BUILD, flags/BUILD, and test_offset_ptr/BUILD to use local package refs instead of @score_baselibs//score/memory/shared cross-repo refs.
KrishaDeshkool
force-pushed
the
memory-migration
branch
from
c09e154 to
075f473
Compare
Add cc_library targets that were present in upstream baselibs but missing from the communication BUILD after migration: - lock_file, shared_memory_resource, i_shared_memory_factory - shared_memory_factory, shared_memory_factory_impl, shared_memory_factory_mock - shared, new_delete_delegate_resource, shared_memory_test_resources - shared_memory_resource_heap_allocator_mock, shared_memory_resource_mock - my_bounded_shared_memory_resource (in fake/) Add missing test targets: - lock_file_test, managed_memory_resource_test, memory_resource_proxy_test - new_delete_delegate_resource_test, shared_memory_factory_test - shared_memory_resource_*_test (allocate, create, open, misc, anonymous) Update unit_test_suite to include all tests and sub-packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.