Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryLow Risk Overview The command calls Written by Cursor Bugbot for commit dba06ea. Configure here. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
| return nil | ||
| } | ||
| } |
There was a problem hiding this comment.
Duplicated run logic between stablecoins and balances commands
Low Severity
runStablecoins is a near-verbatim copy of runBalances — the only differences are the API endpoint path and the omission of the asset-class flag. The flag definitions in NewStablecoinsCmd are similarly duplicated. A shared helper accepting the endpoint path (and optionally registering extra flags) would eliminate ~60 lines of duplication and ensure future bug fixes (e.g., to table rendering or param building) are applied consistently.
There was a problem hiding this comment.
Agree, can we dedupe some of it ?
| } | ||
| return nil | ||
| } | ||
| } |
There was a problem hiding this comment.
Agree, can we dedupe some of it ?
2 participants
Add
dune sim evm stablecoins <address>for querying stablecoin balances across EVM chains with --chain-ids, --filters, --exclude-spam, --historical-prices flags. Reuses balancesResponse types from the balances command.