Skip to content

Fix updating pre-0.18.2 gateways (including Sky) #3658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvstme merged 1 commit into from
Mar 13, 2026
Merged

Fix updating pre-0.18.2 gateways (including Sky) #3658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/dstack/_internal/server/services/gateways/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
)
from dstack._internal.core.models.backends.base import BackendType
from dstack._internal.core.models.gateways import (
AnyGatewayRouterConfig,
Gateway,
GatewayComputeConfiguration,
GatewayConfiguration,
Expand Down Expand Up @@ -707,12 +708,10 @@ async def _update_gateway(gateway_compute_model: GatewayComputeModel, build: str
gateway_compute_model.ssh_private_key,
)
logger.debug("Updating gateway %s", connection.ip_address)
compute_config = GatewayComputeConfiguration.__response__.parse_raw(
gateway_compute_model.configuration
)
router = _get_gateway_compute_router_config(gateway_compute_model)

# Build package spec with extras and wheel URL
gateway_package = get_dstack_gateway_wheel(build, compute_config.router)
gateway_package = get_dstack_gateway_wheel(build, router)
commands = [
# prevent update.sh from overwriting itself during execution
"cp dstack/update.sh dstack/_update.sh",
Expand All @@ -732,6 +731,17 @@ def _recently_updated(gateway_compute_model: GatewayComputeModel) -> bool:
) > get_current_datetime() - timedelta(seconds=60)


def _get_gateway_compute_router_config(
compute: GatewayComputeModel,
) -> Optional[AnyGatewayRouterConfig]:
if compute.configuration is None: # pre-0.18.2 gateway
return None # gateway routers introduced in 0.19.38
compute_config: GatewayComputeConfiguration = (
GatewayComputeConfiguration.__response__.parse_raw(compute.configuration)
)
return compute_config.router


# NOTE: dstack Sky imports and uses this function
async def configure_gateway(
connection: GatewayConnection,
Expand Down
Loading