Skip to content

bug/HOP-32#30

Open
Girik1105 wants to merge 5 commits intodevelopfrom
bug/HOP-32
Open

bug/HOP-32#30
Girik1105 wants to merge 5 commits intodevelopfrom
bug/HOP-32

Conversation

@Girik1105
Copy link
Contributor

@Girik1105 Girik1105 commented Mar 17, 2026

Guidelines for Pull Requests

If you haven't yet read our code review guidelines, please do so, You can find them here.

Please confirm the following by adding an x for each item (turn [ ] into [x]).

  • I have removed all code style changes that are not necessary (e.g. changing blanks across the whole file that don’t need to be changed, adding empty lines in parts other than your own code)
  • I am not making any changes to files that don’t have any effect (e.g. imports added that don’t need to be added)
  • I do not have any sysout statements in my code or commented out code that isn’t needed anymore
  • I am not reformatting any files in the wrong format or without cause.
  • I am not changing file encoding or line endings to something else than UTF-8, LF
  • My pull request does not show an insane amount of files being changed although my ticket only requires a few files being changed
  • I have added Javadoc/documentation where appropriate
  • I have added test cases where appropriate
  • I have explained any part of my code/implementation decisions that is not be self-explanatory

Please provide a brief description of your ticket

After deleting all conversations, the list of conversations in the left menu is not cleared.

Description

I need to reload the page so that the menu gets cleared.

HOP-32

Anything else the reviewer needs to know?

Does this Pull request depend on any other?

@diging-jenkins
Copy link

Can one of the admins verify this patch?

const modal = bootstrap.Modal.getInstance(document.getElementById('deleteHistoryModal'));
modal.hide();
showAlert('danger', 'Something went wrong. Please try again.');
// ignore error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to ignore the error; the user should know there was an error and it should be logged.

document.getElementById('confirmDeleteHistory').addEventListener('click', async function () {
const csrfToken = '{{ csrf_token }}';
const modal = bootstrap.Modal.getInstance(document.getElementById('deleteHistoryModal'));
modal.hide();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably want a spinning indicator or something while the deletion process happens. otherwise if it takes a long time, the user will think nothing is happening.

@jdamerow jdamerow closed this Mar 17, 2026
@Girik1105 Girik1105 reopened this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants