Open
Conversation
|
Can one of the admins verify this patch? |
jdamerow
requested changes
Mar 17, 2026
| const modal = bootstrap.Modal.getInstance(document.getElementById('deleteHistoryModal')); | ||
| modal.hide(); | ||
| showAlert('danger', 'Something went wrong. Please try again.'); | ||
| // ignore error |
Member
There was a problem hiding this comment.
I don't think we want to ignore the error; the user should know there was an error and it should be logged.
| document.getElementById('confirmDeleteHistory').addEventListener('click', async function () { | ||
| const csrfToken = '{{ csrf_token }}'; | ||
| const modal = bootstrap.Modal.getInstance(document.getElementById('deleteHistoryModal')); | ||
| modal.hide(); |
Member
There was a problem hiding this comment.
we probably want a spinning indicator or something while the deletion process happens. otherwise if it takes a long time, the user will think nothing is happening.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines for Pull Requests
If you haven't yet read our code review guidelines, please do so, You can find them here.
Please confirm the following by adding an x for each item (turn
[ ]into[x]).Please provide a brief description of your ticket
After deleting all conversations, the list of conversations in the left menu is not cleared.
Description
I need to reload the page so that the menu gets cleared.
HOP-32
Anything else the reviewer needs to know?
Does this Pull request depend on any other?