Deprecate: deprecate all methods of parameters.py#170
Merged
sbillinge merged 8 commits intodiffpy:v3.3.0from Mar 16, 2026
Merged
Deprecate: deprecate all methods of parameters.py#170sbillinge merged 8 commits intodiffpy:v3.3.0from
parameters.py#170sbillinge merged 8 commits intodiffpy:v3.3.0from
Conversation
Contributor
Author
|
@sbillinge ready for review |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.3.0 #170 +/- ##
==========================================
+ Coverage 78.40% 78.60% +0.19%
==========================================
Files 24 24
Lines 3700 3734 +34
==========================================
+ Hits 2901 2935 +34
Misses 799 799
🚀 New features to boost your workflow:
|
Contributor
|
Nice. Thanks for the tests and the careful thought |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to method deprecation, I replaced
AttributeswithParametersin function docstrings everywhere. Also, turnedprocessMetaDatainto a private function.