Skip to content

Perf batch 1 v5#464

Open
timcadman wants to merge 9 commits intov7.0-devfrom
perf-batch-1-v5
Open

Perf batch 1 v5#464
timcadman wants to merge 9 commits intov7.0-devfrom
perf-batch-1-v5

Conversation

@timcadman
Copy link

@timcadman timcadman commented Mar 16, 2026

Description of changes

  • Refactored absDS, asDataMatrixDS, asIntegerDS, listDS, asLogicalDS, asMatrixDS and asNumericDS.
  • Created serverside function expDS and logDS as these previously didn't exist.
  • Extended .loadServersideObject to handle both object names and column names as input.
  • Added performance tests.
  • Updated test expectations following refactor.

Instructions & checklist for PR reviewers

Code review

  • Check that object is loaded via .loadServersideObject and not with eval.
  • Check that if class checks were previously present on the clientside they have been added to the serverside.
  • Check that performance tests have been added for all functions unless they already existed.
  • Check tests have been updated to reflect changed expectations.

Testing

  • Clone dsBaseClient using branch perf-batch-1.
  • Install dsBase on a test server based on this branch.
  • Run devtools::test( ) on the clientside package and check all tests pass
  • Run devtools::build( ) on the clientside package and check it builds without errors
  • Run devtools::test( ) on the serverside package and check all tests pass
  • Run devtools::build( ) on the serverside package and check it builds without errors

@timcadman timcadman changed the base branch from master to v7.0-dev March 16, 2026 13:56
@timcadman timcadman marked this pull request as ready for review March 16, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant