fix: error messages when compiling tests for incremental tables#2118
Open
ashish10alex wants to merge 1 commit intodataform-co:mainfrom
Open
fix: error messages when compiling tests for incremental tables#2118ashish10alex wants to merge 1 commit intodataform-co:mainfrom
ashish10alex wants to merge 1 commit intodataform-co:mainfrom
Conversation
Contributor
|
/gcbrun |
kolina
approved these changes
Mar 21, 2026
| new Error(ambiguousActionNameMsg(this.datasetToTest, allResolved)), | ||
| this.proto.fileName | ||
| ); | ||
| return this.proto; |
Contributor
There was a problem hiding this comment.
It may still be useful to collect all compilation errors. But I'm fine to have early return as well
Contributor
Author
There was a problem hiding this comment.
I initially had it collect everything. However, that resulted in confusing compilation message such as ""Test query is empty." being added for the user due to code trying to parse query object which will not be populated. Which is why opted for the early return.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Solves: bug: incorrect error message when adding tests for incremental table type #2117
Avoid "Test query is empty." error for the same file by avoiding this check and returning
this.protoearly.dataform/core/actions/test.ts
Line 196 in 412d523
Added unit test for expected behavior
Tests